spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive ser...
Date Mon, 06 Feb 2017 20:36:37 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16626#discussion_r99677955
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -763,7 +763,9 @@ object DDLUtils {
       val HIVE_PROVIDER = "hive"
     
       def isHiveTable(table: CatalogTable): Boolean = {
    -    table.provider.isDefined && table.provider.get.toLowerCase == HIVE_PROVIDER
    +    // When `CatalogTable` is directly fetched from the catalog,
    +    // CatalogTable.provider = None means the table is a Hive serde table.
    +    !table.provider.isDefined || table.provider.get.toLowerCase == HIVE_PROVIDER
    --- End diff --
    
    The provider could be empty if the table is a VIEW. Thus, please do not modify the utility
function here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message