spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anabranch <...@git.apache.org>
Subject [GitHub] spark pull request #16138: [SPARK-16609] Add to_date/to_timestamp with forma...
Date Fri, 03 Feb 2017 16:30:04 GMT
Github user anabranch commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16138#discussion_r99371741
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
    @@ -1047,6 +1048,69 @@ case class ToDate(child: Expression) extends UnaryExpression with
ImplicitCastIn
     }
     
     /**
    + * Parses a column to a date based on the given format.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(date_str, fmt) - Parses the `left` expression with the `fmt` expression.
Returns null with invalid input.",
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_('2016-12-31', 'yyyy-MM-dd');
    +       2016-12-31
    +  """)
    +// scalastyle:on line.size.limit
    +case class ParseToDate(left: Expression, format: Option[Expression], child: Expression)
    +  extends RuntimeReplaceable {
    +
    +  def this(left: Expression, format: Expression) {
    +      this(left, Option(format),
    +        Cast(Cast(UnixTimestamp(left, format), TimestampType), DateType))
    +  }
    +
    +  def this(left: Expression) = {
    +    // backwards compatability
    +    this(left, Option(null), ToDate(left))
    +  }
    +
    +  override def flatArguments: Iterator[Any] = Iterator(left, format)
    +  override def sql: String = {
    +    if (format.isDefined) {
    +      s"$prettyName(${left.sql}, ${format.get.sql}"
    +    } else {
    +      s"$prettyName(${left.sql})"
    +    }
    +  }
    +
    +  override def prettyName: String = "to_date"
    +}
    +
    +/**
    + * Parses a column to a timestamp based on the supplied format.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(timestamp, fmt) - Parses the `left` expression with the `format` expression
to a timestamp. Returns null with invalid input.",
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_('2016-12-31', 'yyyy-MM-dd');
    +       2016-12-31 00:00:00.0
    +  """)
    +// scalastyle:on line.size.limit
    +case class ParseToTimestamp(left: Expression, format: Expression, child: Expression)
    +  extends RuntimeReplaceable {
    +
    +  def this(left: Expression, format: Expression) = {
    +  this(left, format, Cast(UnixTimestamp(left, format), TimestampType))
    +}
    +
    +  override def flatArguments: Iterator[Any] = Iterator(left, format)
    +  override def sql: String = s"$prettyName(${left.sql}, ${format.sql})"
    --- End diff --
    
    No, `to_timestamp` doesn't exist at all in hive, it's a brand new Spark SQL only function.
I also can't actually find a failure in the test results. Do you know what actually failed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message