spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #16664: [SPARK-18120 ][SQL] Call QueryExecutionListener c...
Date Thu, 02 Feb 2017 07:11:40 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16664#discussion_r99062495
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -218,7 +246,17 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
           bucketSpec = getBucketSpec,
           options = extraOptions.toMap)
     
    -    dataSource.write(mode, df)
    +    val destination = source match {
    +      case "jdbc" => extraOptions.get("dbtable")
    +      case _ => extraOptions.get("path")
    +    }
    +
    +    executeAndCallQEListener(
    +      "save",
    +      df.queryExecution,
    +      OutputParams(source, destination, extraOptions.toMap)) {
    +      dataSource.write(mode, df)
    +    }
    --- End diff --
    
    Nit: the style issue.
    ```Scala
        withAction("save", df.queryExecution, OutputParams(source, destination, extraOptions.toMap))
{
          dataSource.write(mode, df)
        }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message