spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...
Date Wed, 01 Feb 2017 06:33:22 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16720#discussion_r98834936
  
    --- Diff: R/pkg/inst/tests/testthat/test_utils.R ---
    @@ -17,6 +17,9 @@
     
     context("functions in utils.R")
     
    +# Ensure Spark is installed
    +sparkCheckInstall()
    --- End diff --
    
    I understand that, but as pointed out https://github.com/apache/spark/pull/16720#issuecomment-275832013,
some tests don't need SparkSession, and some tests will create/stop one as needed, and to
have a function that does that all just mean more complicity?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message