Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16474-spark@git.apache.org>
In-Reply-To: <git-pr-16474-spark@git.apache.org>
Subject: [GitHub] spark pull request #16474: [SPARK-19082][SQL] Make ignoreCorruptFiles work f...
Content-Type: text/plain
Message-Id: <20170112120124.953EBDFA22@git1-us-west.apache.org>
Date: Thu, 12 Jan 2017 12:01:24 +0000 (UTC)
archived-at: Thu, 12 Jan 2017 12:01:26 -0000

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16474#discussion_r95777107
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala ---
    @@ -135,11 +135,21 @@ class FileScanRDD(
               try {
                 if (ignoreCorruptFiles) {
                   currentIterator = new NextIterator[Object] {
    -                private val internalIter = readFunction(currentFile)
    +                private val internalIter = {
    +                  try {
    +                    // The readFunction may read files before consuming the iterator.
    +                    // E.g., vectorized Parquet reader.
    +                    readFunction(currentFile)
    +                  } catch {
    +                    case e @(_: RuntimeException | _: IOException) =>
    +                      logWarning(s"Skipped the rest content in the corrupted file: $currentFile", e)
    +                      null
    --- End diff --
    
    return `Iterator.empty`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org