Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: sethah <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16441-spark@git.apache.org>
In-Reply-To: <git-pr-16441-spark@git.apache.org>
Subject: [GitHub] spark pull request #16441: [SPARK-14975][ML] Fixed GBTClassifier to predict ...
Content-Type: text/plain
Message-Id: <20170111020313.18531DFB7D@git1-us-west.apache.org>
Date: Wed, 11 Jan 2017 02:03:13 +0000 (UTC)
archived-at: Wed, 11 Jan 2017 02:03:15 -0000

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16441#discussion_r95495249
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
    @@ -275,18 +316,33 @@ class GBTClassificationModel private[ml](
       @Since("2.0.0")
       lazy val featureImportances: Vector = TreeEnsembleModel.featureImportances(trees, numFeatures)
     
    +  private def margin(features: Vector): Double = {
    --- End diff --
    
    minor: add doc `/** Raw prediction for each class label */`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org