spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From windpiger <...@git.apache.org>
Subject [GitHub] spark pull request #16545: [SPARK-19166][SQL]rename from InsertIntoHadoopFsR...
Date Wed, 11 Jan 2017 07:01:20 GMT
GitHub user windpiger opened a pull request:

    https://github.com/apache/spark/pull/16545

    [SPARK-19166][SQL]rename from InsertIntoHadoopFsRelationCommand.deleteMatchingPartitions
to InsertIntoHadoopFsRelationCommand.deleteMatchingPrefix

    ## What changes were proposed in this pull request?
    
    InsertIntoHadoopFsRelationCommand.deleteMatchingPartitions delete all files that match
a static prefix, such as a partition file path(/table/foo=1), or a no partition file path(/xxx/a.json).
    
    while the method name deleteMatchingPartitions indicates that only the partition file
will be deleted. This name make a confused.
    
    It is better to rename the method name.
    
    ## How was this patch tested?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/windpiger/spark modifyAMethodName

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16545
    
----
commit 0622c04c6129ef699ca0d8f6907d8bbc6d025387
Author: windpiger <songjun@outlook.com>
Date:   2017-01-11T06:59:22Z

    [SPARK-19166][SQL]change method name from InsertIntoHadoopFsRelationCommand.deleteMatchingPartitions
to InsertIntoHadoopFsRelationCommand.deleteMatchingPrefix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message