spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ethanluoyc <...@git.apache.org>
Subject [GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...
Date Mon, 30 Jan 2017 15:43:36 GMT
Github user ethanluoyc commented on the issue:

    https://github.com/apache/spark/pull/15279
  
    @felixcheung I actually agree with you on examples being self contained. In that case,
the example authors can just declare the arguments in the examples. 
    
    What I think may be appropriate will be some macro kind of text in the examples themselves.
(e.g. like an shebang line but for files.) Then instead of looking for the arguments in the
yml we can look for it in the examples. 
    
    Another way to do it will be to let the examples be ready in passing in their own default
arguments. But I would not say this is a good idea because then all examples will need to
be modified.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message