spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From windpiger <...@git.apache.org>
Subject [GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...
Date Fri, 27 Jan 2017 01:30:46 GMT
Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16700#discussion_r98130978
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
---
    @@ -839,6 +839,25 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf:
Configurat
         spec.map { case (k, v) => partCols.find(_.equalsIgnoreCase(k)).get -> v }
       }
     
    +
    +  /**
    +   * partition path created by Hive is lower-case, while Spark SQL will
    +   * rename it with the partition name in partitionColumnNames, and this function
    +   * return the extra lower-case path created by Hive, and then we can delete it.
    +   * e.g. /path/A=1/B=2/C=3 rename to /path/A=4/B=5/C=6, the extra path returned is
    +   * /path/a=4, which also include all its' child path, such as /path/a=4/b=2
    +   */
    +  def getExtraPartPathCreatedByHive(
    +                                     lowerCaseSpec: TablePartitionSpec,
    +                                     partitionColumnNames: Seq[String],
    +                                     tablePath: Path): Path = {
    --- End diff --
    
    oh...sorry...thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message