spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request #16706: [SPARK-19365][Core]Optimize RequestMessage serial...
Date Thu, 26 Jan 2017 20:02:37 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16706#discussion_r98072101
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEndpointAddress.scala ---
    @@ -25,10 +27,11 @@ import org.apache.spark.SparkException
      * The `rpcAddress` may be null, in which case the endpoint is registered via a client-only
      * connection and can only be reached via the client that sent the endpoint reference.
      *
    - * @param rpcAddress The socket address of the endpoint.
    + * @param rpcAddress The socket address of the endpoint. It's `null` when this address
pointing to
    + *                   an endpoint in a client `NettyRpcEnv`.
      * @param name Name of the endpoint.
      */
    -private[spark] case class RpcEndpointAddress(val rpcAddress: RpcAddress, val name: String)
{
    +private[spark] case class RpcEndpointAddress(@Nullable rpcAddress: RpcAddress, name:
String) {
    --- End diff --
    
    +1 we could add a comment there instead of pulling in a new annotation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message