spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request #16536: [SPARK-19163][PYTHON][SQL] Delay _judf initializa...
Date Thu, 26 Jan 2017 19:51:26 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16536#discussion_r98077102
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -1826,19 +1826,27 @@ class UserDefinedFunction(object):
         def __init__(self, func, returnType, name=None):
             self.func = func
             self.returnType = returnType
    -        self._judf = self._create_judf(name)
    -
    -    def _create_judf(self, name):
    +        self._judf_placeholder = None
    +        self._name = name or (
    +            func.__name__ if hasattr(func, '__name__')
    +            else func.__class__.__name__)
    +
    +    @property
    +    def _judf(self):
    +        if self._judf_placeholder is None:
    --- End diff --
    
    Ok, I'd maybe just leave a comment saying that we've left out the lock since double creation
is both unlikely and OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message