spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #14461: [SPARK-16856] [WEBUI] [CORE] Link the application...
Date Wed, 25 Jan 2017 22:47:53 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14461#discussion_r97897928
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -126,7 +126,8 @@ case class SparkListenerApplicationStart(
         time: Long,
         sparkUser: String,
         appAttemptId: Option[String],
    -    driverLogs: Option[Map[String, String]] = None) extends SparkListenerEvent
    +    driverLogs: Option[Map[String, String]] = None,
    +    masterWebUiUrl: Option[String] = None) extends SparkListenerEvent
    --- End diff --
    
    Do you need this? It seems the standalone registration messages already take care of this.
    
    If you want this, are you intentionally not saving this in event logs? The way it is,
this is only ever useful when the application is starting but hasn't yet registered with the
master. That's a very short period of time and probably not worth it.
    
    If you add code to save to event logs, I'd rename this to be more cluster manager-agnostic.
e.g. "clusterWebUiUrl".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message