spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #16138: [SPARK-16609] Add to_date/to_timestamp with forma...
Date Tue, 24 Jan 2017 07:53:13 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16138#discussion_r97490239
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
    @@ -1047,6 +1048,64 @@ case class ToDate(child: Expression) extends UnaryExpression with
ImplicitCastIn
     }
     
     /**
    + * Parses a column to a date based on the given format.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(date_str, fmt) - Parses the `left` expression with the `fmt` expression.
Returns null with invalid input.",
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_('2016-12-31', 'yyyy-MM-dd');
    +       2016-12-31
    +  """)
    +// scalastyle:on line.size.limit
    +case class ParseToDate(left: Expression, format: Expression, child: Expression)
    +  extends RuntimeReplaceable {
    +
    +  def this(left: Expression, format: Expression) = {
    +    this(left, format, Cast(Cast(new UnixTimestamp(left, format), TimestampType), DateType))
    +  }
    +
    +  def this(left: Expression) = {
    +    // RuntimeReplaceable forces the signature, the second value
    +    // is ignored completely
    +    this(left, Literal(""), ToDate(left))
    +  }
    +
    +  override def flatArguments: Iterator[Any] = Iterator(left, format)
    +  override def sql: String = s"$prettyName(${left.sql}, ${format.sql})"
    +
    +  override def prettyName: String = "to_date"
    +  override def dataType: DataType = DateType
    --- End diff --
    
    this is already defined in `RuntimeReplaceable`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message