spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is ...
Date Sun, 22 Jan 2017 18:24:25 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16670#discussion_r97229573
  
    --- Diff: R/pkg/inst/tests/testthat/test_Windows.R ---
    @@ -20,7 +20,7 @@ test_that("sparkJars tag in SparkContext", {
       if (.Platform$OS.type != "windows") {
         skip("This test is only for Windows, skipped")
       }
    -  testOutput <- launchScript("ECHO", "a/b/c", capture = TRUE)
    +  testOutput <- launchScript("ECHO", "a/b/c", wait = TRUE)
    --- End diff --
    
    I see - I expected the stdout = "" to be piping it to the R process stdout. We could also
explicitly pass a `fd` to do this pipe ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message