spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markhamstra <>
Subject [GitHub] spark pull request #16620: [SPARK-19263] DAGScheduler should avoid sending c...
Date Fri, 20 Jan 2017 19:42:40 GMT
Github user markhamstra commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1193,7 +1193,15 @@ class DAGScheduler(
                 if (runningStages.contains(shuffleStage) && shuffleStage.pendingPartitions.isEmpty)
    -              markStageAsFinished(shuffleStage)
    +              val activeTaskSetManagerExist =
    --- End diff --
    And since it is being used as `!activeTaskSetManagerExists`, you could reverse the sense,
avoid needing the `!`, and call it something like `noActiveTaskSetManager`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message