spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #16645: [SPARK-19290][SQL] add a new extending interface ...
Date Thu, 19 Jan 2017 22:46:53 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16645#discussion_r96976789
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala ---
    @@ -62,15 +62,17 @@ private[hive] class HiveSessionState(sparkSession: SparkSession)
           override val extendedResolutionRules =
             catalog.ParquetConversions ::
             catalog.OrcConversions ::
    -        AnalyzeCreateTable(sparkSession) ::
    -        PreprocessTableInsertion(conf) ::
    -        DataSourceAnalysis(conf) ::
             new DetermineHiveSerde(conf) ::
    -        new HiveAnalysis(sparkSession) ::
             new FindDataSourceTable(sparkSession) ::
             new FindHiveSerdeTable(sparkSession) ::
             new ResolveDataSource(sparkSession) :: Nil
     
    +      override val postHocResolutionRules =
    +        AnalyzeCreateTable(sparkSession) ::
    +        PreprocessTableInsertion(conf) ::
    +        DataSourceAnalysis(conf) ::
    +        new HiveAnalysis(sparkSession) :: Nil
    --- End diff --
    
    How about moving the rule `catalog.ParquetConversions` and `catalog.OrcConversions` at
the beginning of this batch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message