spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request #16346: [SPARK-16654][CORE] Add UI coverage for Applicati...
Date Wed, 18 Jan 2017 16:10:08 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16346#discussion_r96668414
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala ---
    @@ -88,6 +91,15 @@ class BlacklistTrackerSuite extends SparkFunSuite with BeforeAndAfterEach
with M
         new TaskSetBlacklist(conf, stageId, clock)
       }
     
    +  def configureBlacklistAndScheduler: Unit = {
    --- End diff --
    
    now that you're doing the equivalent thing in `beforeEach`, this entire method is unnecessary.
 `beforeEach` gets called automatically for each test so you don't need to call this explicitly.
    
    sorry I was unclear about this earlier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message