spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request #16589: [SPARK-19231][SPARKR] add error handling for down...
Date Wed, 18 Jan 2017 05:10:17 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16589#discussion_r96567761
  
    --- Diff: R/pkg/R/install.R ---
    @@ -201,14 +221,20 @@ directDownloadTar <- function(mirrorUrl, version, hadoopVersion,
packageName, pa
       msg <- sprintf(fmt, version, ifelse(hadoopVersion == "without", "Free build", hadoopVersion),
                      packageRemotePath)
       message(msg)
    -  downloadUrl(packageRemotePath, packageLocalPath, paste0("Fetch failed from ", mirrorUrl))
    +  downloadUrl(packageRemotePath, packageLocalPath)
    --- End diff --
    
    I didn't relate this to the update in L176 - I think this is fine. In general I think
this file has gotten a little unwieldy with error messages coming from different functions.
I wonder if there is a better way to refactor things to setup some expectations on where errors
are thrown etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message