spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #16517: [SPARK-18243][SQL] Port Hive writing to use FileF...
Date Wed, 18 Jan 2017 04:39:51 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16517#discussion_r96566662
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
    @@ -276,40 +276,31 @@ case class InsertIntoHiveTable(
           }
         }
     
    -    val jobConf = new JobConf(hadoopConf)
    -    val jobConfSer = new SerializableJobConf(jobConf)
    -
    -    // When speculation is on and output committer class name contains "Direct", we should
warn
    -    // users that they may loss data if they are using a direct output committer.
    -    val speculationEnabled = sqlContext.sparkContext.conf.getBoolean("spark.speculation",
false)
    -    val outputCommitterClass = jobConf.get("mapred.output.committer.class", "")
    -    if (speculationEnabled && outputCommitterClass.contains("Direct")) {
    --- End diff --
    
    the direct commit has been removed already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message