spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #16601: [SPARK-19182][DStream] Optimize the lock in Strea...
Date Wed, 18 Jan 2017 01:30:32 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16601#discussion_r96550577
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala ---
    @@ -31,12 +31,15 @@ final private[streaming] class DStreamGraph extends Serializable with
Logging {
       private val inputStreams = new ArrayBuffer[InputDStream[_]]()
       private val outputStreams = new ArrayBuffer[DStream[_]]()
     
    +  val inputStreamNameAndID = new ArrayBuffer[(String, Int)]()
    +
       var rememberDuration: Duration = null
       var checkpointInProgress = false
     
       var zeroTime: Time = null
       var startTime: Time = null
       var batchDuration: Duration = null
    +  var numReceivers: Int = 0
    --- End diff --
    
    nit: add `@volatile private` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message