spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark issue #16596: [SPARK-19237][SPARKR] R should check for java when insta...
Date Mon, 16 Jan 2017 18:42:50 GMT
Github user shivaram commented on the issue:

    https://github.com/apache/spark/pull/16596
  
    `spark-submit` eventually finds java from https://github.com/apache/spark/blob/a115a54399cd4bedb1a5086943a88af6339fbe85/bin/spark-class#L26
and uses the bash builtin `command` - In fact it looks like using `which` is discouraged (http://stackoverflow.com/a/677212/4577954)
but I'm not sure if we have a better thing to call from R. 
    
    So another way to do this might be to have a `find-java` shell script that is part of
the R package (and thus always available) and call that. But handling windows support etc.
becomes a pain then ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message