spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ueshin <...@git.apache.org>
Subject [GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...
Date Mon, 16 Jan 2017 08:15:47 GMT
Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16308#discussion_r96178830
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
    @@ -32,20 +34,20 @@ import org.apache.spark.unsafe.types.UTF8String
      */
     class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
     
    -  private def cast(v: Any, targetType: DataType): Cast = {
    +  private def cast(v: Any, targetType: DataType, timeZoneId: Option[String] = None):
Cast = {
         v match {
    -      case lit: Expression => Cast(lit, targetType)
    -      case _ => Cast(Literal(v), targetType)
    +      case lit: Expression => Cast(lit, targetType, timeZoneId)
    +      case _ => Cast(Literal(v), targetType, timeZoneId)
         }
       }
     
       // expected cannot be null
    -  private def checkCast(v: Any, expected: Any): Unit = {
    -    checkEvaluation(cast(v, Literal(expected).dataType), expected)
    +  private def checkCast(v: Any, expected: Any, timeZoneId: Option[String] = None): Unit
= {
    --- End diff --
    
    Ah, I prepared for the parameter before but this is not called with `timeZoneId` parameter.
    I'll remove this parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message