spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #16474: [SPARK-19082][SQL] Make ignoreCorruptFiles work f...
Date Thu, 12 Jan 2017 12:00:52 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16474#discussion_r95777029
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
    @@ -135,11 +135,21 @@ class FileScanRDD(
               try {
                 if (ignoreCorruptFiles) {
                   currentIterator = new NextIterator[Object] {
    -                private val internalIter = readFunction(currentFile)
    +                private val internalIter = {
    +                  try {
    +                    // The readFunction may read files before consuming the iterator.
    +                    // E.g., vectorized Parquet reader.
    +                    readFunction(currentFile)
    +                  } catch {
    +                    case e @(_: RuntimeException | _: IOException) =>
    --- End diff --
    
    shall we also check the error message? or `RuntimeException` may catch other unexpected
exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message