spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn...
Date Wed, 11 Jan 2017 03:12:50 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16387#discussion_r95505432
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
    @@ -192,12 +193,16 @@ class ExternalAppendOnlyMap[K, V, C](
        * It will be called by TaskMemoryManager when there is not enough memory for the task.
        */
       override protected[this] def forceSpill(): Boolean = {
    -    assert(readingIterator != null)
    -    val isSpilled = readingIterator.spill()
    -    if (isSpilled) {
    -      currentMap = null
    +    if (isReadingIterator) {
    +      assert(readingIterator != null)
    +      val isSpilled = readingIterator.spill()
    +      if (isSpilled) {
    +        currentMap = null
    +      }
    +      isSpilled
    +    } else {
    +      false
    --- End diff --
    
    Sorry, you're right, so let me rephrase: is there any reason not to try to spill the current
map if the iterator hasn't been instantiated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message