spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #16497: [SPARK-19118] [SQL] Percentile support for freque...
Date Tue, 10 Jan 2017 04:14:33 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16497#discussion_r95297633
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
    @@ -126,10 +152,15 @@ case class Percentile(
           buffer: OpenHashMap[Number, Long],
           input: InternalRow): OpenHashMap[Number, Long] = {
         val key = child.eval(input).asInstanceOf[Number]
    +    val frqValue = frequency.eval(input)
     
         // Null values are ignored in counts map.
    -    if (key != null) {
    -      buffer.changeValue(key, 1L, _ + 1L)
    +    if (key != null && frqValue != null) {
    +      val frqLong = frqValue.asInstanceOf[Number].longValue()
    +      // add only when frequency is positive
    +      if (frqLong > 0) {
    --- End diff --
    
    Lets make this a requirement and fail when the value < 0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message