spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark issue #16503: [SPARK-18113] canCommit should return same when called b...
Date Mon, 09 Jan 2017 22:47:30 GMT
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/16503
  
    Good catch. Looks good to me.
    
    @vanzin The RPC layer only guarantees at-most-once. Retry may be still helpful in some
case, but the receiver should be idempotent. Either the current change or changing to use
`ask` (Spark will retry the task) is good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message