spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ericl <...@git.apache.org>
Subject [GitHub] spark issue #15539: [SPARK-17994] [SQL] Add back a file status cache for cat...
Date Sun, 08 Jan 2017 20:52:32 GMT
Github user ericl commented on the issue:

    https://github.com/apache/spark/pull/15539
  
    That one is safe to make global but mutable right? It will take effect
    after a table is refreshed.
    
    Most of these anomalies seem OK to me provided we document them -- it seems
    to solve them we would have to cache per session which would significantly
    increase memory required.
    
    On Sun, Jan 8, 2017, 9:32 AM Xiao Li <notifications@github.com> wrote:
    
    > *@gatorsmile* commented on this pull request.
    > ------------------------------
    >
    > In
    > sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala
    > <https://github.com/apache/spark/pull/15539>:
    >
    > > +   * Invalidates all data held by this cache.
    > +   */
    > +  def invalidateAll(): Unit
    > +}
    > +
    > +object FileStatusCache {
    > +  private var sharedCache: SharedInMemoryCache = null
    > +
    > +  /**
    > +   * @return a new FileStatusCache based on session configuration. Cache memory
quota is
    > +   *         shared across all clients.
    > +   */
    > +  def newCache(session: SparkSession): FileStatusCache = {
    > +    synchronized {
    > +      if (session.sqlContext.conf.filesourcePartitionPruning &&
    > +          session.sqlContext.conf.filesourcePartitionFileCacheSize > 0) {
    >
    > How about HIVE_MANAGE_FILESOURCE_PARTITIONS?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/15539>, or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AAA6SkueCftKjbFVS9-G790WmFj-NA1Gks5rQR24gaJpZM4KabFw>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message