spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #16491: [SPARK-19110][ML][MLLIB]:DistributedLDAModel retu...
Date Fri, 06 Jan 2017 22:48:13 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16491#discussion_r95034707
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala ---
    @@ -260,6 +260,14 @@ class LDASuite extends SparkFunSuite with MLlibTestSparkContext with
DefaultRead
             Vectors.dense(model2.topicsMatrix.toArray) absTol 1e-6)
           assert(Vectors.dense(model.getDocConcentration) ~==
             Vectors.dense(model2.getDocConcentration) absTol 1e-6)
    +      val logPrior = model.asInstanceOf[DistributedLDAModel].logPrior
    +      val logPrior2 = model2.asInstanceOf[DistributedLDAModel].logPrior
    +      val trainingLogLikelihood =
    +        model.asInstanceOf[DistributedLDAModel].trainingLogLikelihood
    +      val trainingLogLikelihood2 =
    +        model2.asInstanceOf[DistributedLDAModel].trainingLogLikelihood
    +      assert(logPrior ~== logPrior2 absTol 1e-6)
    +      assert(trainingLogLikelihood ~== trainingLogLikelihood2 absTol 1e-6)
    --- End diff --
    
    should we check trainingLogLikelihood and logPrior are not changing for LocalLDAModel?
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message