spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...
Date Tue, 03 Jan 2017 04:10:42 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16320#discussion_r94358447
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
    @@ -85,7 +85,9 @@ private[csv] object CSVInferSchema {
             case NullType => tryParseInteger(field, options)
             case IntegerType => tryParseInteger(field, options)
             case LongType => tryParseLong(field, options)
    -        case _: DecimalType => tryParseDecimal(field, options)
    +        case _: DecimalType =>
    +          // DecimalTypes have different precisions and scales, so we try to find the
common type.
    +          findTightestCommonType(typeSoFar, tryParseDecimal(field, options)).getOrElse(NullType)
    --- End diff --
    
    Yes, otherwise, it might end up with an incorrect datatypes. For example,
    
    ```scala
    val path = "/tmp/test1"
    Seq(s"${Long.MaxValue}1", "2015-12-01 00:00:00", "1").toDF().coalesce(1).write.text(path)
    spark.read.option("inferSchema", true).csv(path).printSchema()
    ```
    
    ```
    root
     |-- _c0: integer (nullable = true)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message