spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...
Date Sun, 01 Jan 2017 19:22:39 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16304#discussion_r94287885
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
    @@ -124,6 +137,33 @@ class WatermarkSuite extends StreamTest with BeforeAndAfter with
Logging {
         )
       }
     
    +  test("delay in months and years handled correctly") {
    +    val currentTimeMs = System.currentTimeMillis
    +    val currentTime = new Date(currentTimeMs)
    +
    +    val input = MemoryStream[Long]
    +    val aggWithWatermark = input.toDF()
    +      .withColumn("eventTime", $"value".cast("timestamp"))
    +      .withWatermark("eventTime", "2 years 5 months")
    +      .groupBy(window($"eventTime", "5 seconds") as 'window)
    +      .agg(count("*") as 'count)
    +      .select($"window".getField("start").cast("long").as[Long], $"count".as[Long])
    +
    +    def monthsSinceEpoch(date: Date): Int = { date.getYear * 12 + date.getMonth }
    +
    +    testStream(aggWithWatermark)(
    +      AddData(input, currentTimeMs / 1000),
    +      CheckAnswer(),
    +      AddData(input, currentTimeMs / 1000),
    +      CheckAnswer(),
    +      assertEventStats { e =>
    +        assert(timestampFormat.parse(e.get("max")).getTime === (currentTimeMs / 1000)
* 1000)
    +        val watermarkTime = timestampFormat.parse(e.get("watermark"))
    +        assert(monthsSinceEpoch(currentTime) - monthsSinceEpoch(watermarkTime) === 29)
    --- End diff --
    
    All the recent builds failed in this check.
    ```
    [info] - delay in months and years handled correctly *** FAILED *** (325 milliseconds)
    [info]   30 did not equal 29 (EventTimeWatermarkSuite.scala:193)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message