Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: srowen <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16440-spark@git.apache.org>
In-Reply-To: <git-pr-16440-spark@git.apache.org>
Subject: [GitHub] spark pull request #16440: [SPARK-18857][SQL] Don't use `Iterator.duplicate`...
Content-Type: text/plain
Message-Id: <20161231120536.A7E87DFC3B@git1-us-west.apache.org>
Date: Sat, 31 Dec 2016 12:05:36 +0000 (UTC)
archived-at: Sat, 31 Dec 2016 12:05:38 -0000

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16440#discussion_r94272507
  
    --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala ---
    @@ -103,6 +103,10 @@ private[hive] class SparkExecuteStatementOperation(
         }
       }
     
    +  private def useIncrementalCollect: Boolean = {
    --- End diff --
    
    Does this need to be a `def`? will it ever change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org