Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: kiszk <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16403-spark@git.apache.org>
In-Reply-To: <git-pr-16403-spark@git.apache.org>
Subject: [GitHub] spark pull request #16403: [SPARK-18819][CORE] Double byte alignment on ARM ...
Content-Type: text/plain
Message-Id: <20161230184508.56BEDDFB6F@git1-us-west.apache.org>
Date: Fri, 30 Dec 2016 18:45:08 +0000 (UTC)
archived-at: Fri, 30 Dec 2016 18:45:10 -0000

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16403#discussion_r94249364
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java ---
    @@ -244,6 +251,18 @@ public static void throwException(Throwable t) {
           LONG_ARRAY_OFFSET = _UNSAFE.arrayBaseOffset(long[].class);
           FLOAT_ARRAY_OFFSET = _UNSAFE.arrayBaseOffset(float[].class);
           DOUBLE_ARRAY_OFFSET = _UNSAFE.arrayBaseOffset(double[].class);
    +
    +      // determine whether double access should be aligned.
    +      String arch = System.getProperty("os.arch", "");
    +      if (arch.matches("^(arm|arm32)")) {
    --- End diff --
    
    What's happen on ARM 64-bit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org