Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: yhuai <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15996-spark@git.apache.org>
In-Reply-To: <git-pr-15996-spark@git.apache.org>
Subject: [GitHub] spark pull request #15996: [SPARK-18567][SQL] Simplify CreateDataSourceTable...
Content-Type: text/plain
Message-Id: <20161223051539.2CC3BDFBE9@git1-us-west.apache.org>
Date: Fri, 23 Dec 2016 05:15:39 +0000 (UTC)
archived-at: Fri, 23 Dec 2016 05:15:41 -0000

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15996#discussion_r93730700
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala ---
    @@ -643,6 +644,14 @@ class DataFrameReaderWriterSuite extends QueryTest with SharedSQLContext with Be
         withTable("t") {
           val provider = "org.apache.spark.sql.test.DefaultSource"
           sql(s"CREATE TABLE t USING $provider")
    +
    +      // make sure the data source doesn't provide `InsertableRelation`, so that we can only append
    +      // data to it with `CreatableRelationProvider.createRelation`
    --- End diff --
    
    One last comment. Let's explicitly say that we want to test the case that a data source is a CreatableRelationProvider but its relation does not implement InsertableRelation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org