Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16323-spark@git.apache.org>
In-Reply-To: <git-pr-16323-spark@git.apache.org>
Subject: [GitHub] spark pull request #16323: [SPARK-18911] [SQL] Define CatalogStatistics to i...
Content-Type: text/plain
Message-Id: <20161222162517.14FB3DFBAD@git1-us-west.apache.org>
Date: Thu, 22 Dec 2016 16:25:17 +0000 (UTC)
archived-at: Thu, 22 Dec 2016 16:25:18 -0000

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16323#discussion_r93653248
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ---
    @@ -237,6 +239,38 @@ case class CatalogTable(
     }
     
     
    +/**
    + * This class of statistics is used in [[CatalogTable]] to interact with metastore.
    + */
    +case class CatalogStatistics(
    +    sizeInBytes: BigInt,
    +    rowCount: Option[BigInt] = None,
    +    colStats: Map[String, ColumnStat] = Map.empty) {
    +
    +  /**
    +   * Convert [[CatalogStatistics]] to [[Statistics]], and match column stats to attributes based
    +   * on column names.
    +   */
    +  def convert(attributes: Seq[Attribute]): Statistics = {
    --- End diff --
    
    This is a bad name, it doesn't tell anything, without looking at the doc. How about `def toPlanStats(planOuput: ...)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org