Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: zsxwing <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16219-spark@git.apache.org>
In-Reply-To: <git-pr-16219-spark@git.apache.org>
Subject: [GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...
Content-Type: text/plain
Message-Id: <20161209194321.C0622E36E0@git1-us-west.apache.org>
Date: Fri,  9 Dec 2016 19:43:21 +0000 (UTC)
archived-at: Fri, 09 Dec 2016 19:43:23 -0000

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16219#discussion_r91771485
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala ---
    @@ -376,7 +376,9 @@ class StateStoreSuite extends SparkFunSuite with BeforeAndAfter with PrivateMeth
         val opId = 0
         val dir = Utils.createDirectory(tempDir, Random.nextString(5)).toString
         val storeId = StateStoreId(dir, opId, 0)
    -    val storeConf = StateStoreConf.empty
    +    val sqlConf = new SQLConf()
    +    sqlConf.setConf(SQLConf.MIN_BATCHES_TO_RETAIN, 2)
    +    val storeConf = StateStoreConf(sqlConf) // StateStoreConf.empty
    --- End diff --
    
    nit: this is not `StateStoreConf.empty`. Please remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org