spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangmiao1981 <...@git.apache.org>
Subject [GitHub] spark pull request #16284: [SPARK-18865][SparkR]:SparkR vignettes MLP and LD...
Date Wed, 14 Dec 2016 23:15:28 GMT
GitHub user wangmiao1981 opened a pull request:

    https://github.com/apache/spark/pull/16284

    [SPARK-18865][SparkR]:SparkR vignettes MLP and LDA updates

    ## What changes were proposed in this pull request?
    
    When do the QA work, I found that the following issues:
    
    1). `spark.mlp` doesn't include an example;
    2). `spark.mlp` and `spark.lda` have redundant parameter explanations;
    3). `spark.lda` document misses default values for some parameters.
    
    I also changed the `spark.logit` regParam in the examples, as we discussed in #16222.
    
    ## How was this patch tested?
    
    Manual test
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangmiao1981/spark ks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16284
    
----
commit a33262f518e531746d9f28cda2d492c4de373c5f
Author: wm624@hotmail.com <wm624@hotmail.com>
Date:   2016-12-14T22:59:31Z

    remove repeated contents and add example

commit 6a9ded187c51e15ef30873317889f204f251d68d
Author: wm624@hotmail.com <wm624@hotmail.com>
Date:   2016-12-14T23:14:54Z

    update dataset

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message