spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #16248: [SPARK-18810][SPARKR] SparkR install.spark does n...
Date Sun, 11 Dec 2016 07:15:44 GMT
GitHub user felixcheung opened a pull request:

    https://github.com/apache/spark/pull/16248

    [SPARK-18810][SPARKR] SparkR install.spark does not work for RCs, snapshots

    ## What changes were proposed in this pull request?
    
    Support overriding the download url (include version directory) in an environment variable,
`SPARKR_RELEASE_DOWNLOAD_URL`
    
    ## How was this patch tested?
    
    unit test, manually testing
    - snapshot build url
      - download when spark jar not cached
      - when spark jar is cached
    - RC build url
      - download when spark jar not cached
      - when spark jar is cached
    - multiple cached spark version


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/felixcheung/spark rinstallurl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16248
    
----
commit 7c1d95b496784fd7db82e91e207323c071ccda4d
Author: Felix Cheung <felixcheung_m@hotmail.com>
Date:   2016-12-10T00:07:25Z

    changes to support env override url

commit 32a010afb611130cad1b12b5d13f50cde95ba74b
Author: Felix Cheung <felixcheung_m@hotmail.com>
Date:   2016-12-11T07:08:46Z

    change to setup path correctly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message