spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...
Date Thu, 29 Dec 2016 04:51:19 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16422#discussion_r94101398
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
---
    @@ -300,10 +300,12 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
        * Create a [[DescribeTableCommand]] logical plan.
        */
       override def visitDescribeTable(ctx: DescribeTableContext): LogicalPlan = withOrigin(ctx)
{
    -    // Describe column are not supported yet. Return null and let the parser decide
    -    // what to do with this (create an exception or pass it on to a different system).
         if (ctx.describeColName != null) {
    -      null
    +      DescribeColumnCommand(
    --- End diff --
    
    shall we throw exception here if partition spec is given?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message