spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #15664: [SPARK-18123][SQL] Use db column names instead of...
Date Thu, 29 Dec 2016 03:21:13 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15664#discussion_r94098595
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
    @@ -211,6 +211,55 @@ object JdbcUtils extends Logging {
       }
     
       /**
    +   * Returns the schema if the table already exists in the JDBC database.
    +   */
    +  def getSchema(conn: Connection, url: String, table: String): Option[StructType] = {
    +    val dialect = JdbcDialects.get(url)
    +
    +    try {
    +      val statement = conn.prepareStatement(dialect.getSchemaQuery(table))
    +      try {
    +        Some(getSchema(statement.executeQuery(), dialect))
    --- End diff --
    
    `getSchema` will throw an exception when the schema contains an unsupported type. Now
we use it to check if the table exists. Does it change current behavior? E.g., the insertion
working before now fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message