spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanboliang <...@git.apache.org>
Subject [GitHub] spark pull request #15212: [SPARK-17645][MLLIB][ML]add feature selector meth...
Date Fri, 23 Dec 2016 14:00:31 GMT
Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15212#discussion_r93767245
  
    --- Diff: python/pyspark/ml/feature.py ---
    @@ -2629,8 +2629,21 @@ class ChiSqSelector(JavaEstimator, HasFeaturesCol, HasOutputCol,
HasLabelCol, Ja
         """
         .. note:: Experimental
     
    -    Chi-Squared feature selection, which selects categorical features to use for predicting
a
    -    categorical label.
    +    Creates a ChiSquared feature selector.
    +    The selector supports different selection methods: `numTopFeatures`, `percentile`,
`fpr`,
    +    `fdr`, `fwe`.
    +    `numTopFeatures` chooses a fixed number of top features according to a chi-squared
test.
    +    `percentile` is similar but chooses a fraction of all features instead of a fixed
number.
    +    `fpr` chooses all features whose p-value is below a threshold, thus controlling the
false
    +    positive rate of selection.
    +    `fdr` uses the [Benjamini-Hochberg procedure]
    +    (https://en.wikipedia.org/wiki/False_discovery_rate#Benjamini.E2.80.93Hochberg_procedure)
    +    to choose all features whose false discovery rate is below a threshold.
    +    `fwe` chooses all features whose whose p-values is below a threshold,
    --- End diff --
    
    Remove duplicated ```whose```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message