spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...
Date Thu, 22 Dec 2016 23:45:45 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16308#discussion_r93541632
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -104,6 +104,7 @@ class Analyzer(
           ResolveAggregateFunctions ::
           TimeWindowing ::
           ResolveInlineTables ::
    +      ResolveTimeZone ::
    --- End diff --
    
    This seems overkill. We only need to run the rule once, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message