spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stibbons <...@git.apache.org>
Subject [GitHub] spark pull request #14830: [SPARK-16992][PYSPARK][DOCS] import sort and auto...
Date Wed, 21 Dec 2016 11:51:26 GMT
Github user Stibbons commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14830#discussion_r93424082
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -1626,10 +1626,10 @@ See the full [source code]({{site.SPARK_GITHUB_URL}}/blob/v{{site.SPARK_VERSION_
     # Lazily instantiated global instance of SparkSession
     def getSparkSessionInstance(sparkConf):
         if ("sparkSessionSingletonInstance" not in globals()):
    -        globals()["sparkSessionSingletonInstance"] = SparkSession \
    -            .builder \
    -            .config(conf=sparkConf) \
    -            .getOrCreate()
    +        globals()["sparkSessionSingletonInstance"] = (SparkSession
    --- End diff --
    
    my point was on the use of parenthesis instead of thr backslash, which is recommended
by pep8. I can keep the indentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message