spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wzhfy <...@git.apache.org>
Subject [GitHub] spark pull request #16323: [SPARK-18911] [SQL] Define CatalogStatistics to i...
Date Tue, 20 Dec 2016 13:52:34 GMT
Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16323#discussion_r93240303
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
    @@ -198,6 +200,10 @@ case class CatalogTable(
           locationUri, inputFormat, outputFormat, serde, compressed, properties))
       }
     
    +  def withStats(cboStatsEnabled: Boolean): CatalogTable = {
    --- End diff --
    
    Yes I also think that's better, but as @cloud-fan said, we can't get the config in `def
statistics`, we have to modify many places to support this. I'm about to do such modifications,
do you have any advices to minimize the changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message