spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #16284: [SPARK-18865][SparkR]:SparkR vignettes MLP and LD...
Date Wed, 14 Dec 2016 23:43:27 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16284#discussion_r92516301
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -1233,7 +1233,7 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula
= "formula
     #'        docConcentration. Only 1-size or \code{k}-size numeric is accepted.
     #' @param customizedStopWords stopwords that need to be removed from the given corpus.
Ignore the
     #'        parameter if libSVM-format column is used as the features column.
    -#' @param maxVocabSize maximum vocabulary size, default 1 << 18
    +#' @param maxVocabSize maximum vocabulary size, default is 1 << 18
    --- End diff --
    
    `maxVocabSize maximum vocabulary size, default 1 << 18` could still be useful since
the value in the signature is `bitwShiftL(1, 18)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message