spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request #16258: [SPARK-18834][SS] Expose event time and processin...
Date Tue, 13 Dec 2016 00:11:26 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16258#discussion_r92071196
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
    @@ -360,6 +360,24 @@ class StreamExecution(
         if (hasNewData) {
           // Current batch timestamp in milliseconds
           offsetSeqMetadata.batchTimestampMs = triggerClock.getTimeMillis()
    +      // Update the eventTime watermark if we find one in the plan.
    --- End diff --
    
    +1, this makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message