spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ericl <...@git.apache.org>
Subject [GitHub] spark pull request #16135: [SPARK-18700][SQL] Add StripedLock for each table...
Date Mon, 12 Dec 2016 08:49:01 GMT
Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16135#discussion_r91903078
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
---
    @@ -209,72 +221,79 @@ private[hive] class HiveMetastoreCatalog(sparkSession: SparkSession)
extends Log
             }
           }
     
    -      val cached = getCached(
    -        tableIdentifier,
    -        rootPaths,
    -        metastoreRelation,
    -        metastoreSchema,
    -        fileFormatClass,
    -        bucketSpec,
    -        Some(partitionSchema))
    -
    -      val logicalRelation = cached.getOrElse {
    -        val sizeInBytes = metastoreRelation.statistics.sizeInBytes.toLong
    -        val fileCatalog = {
    -          val catalog = new CatalogFileIndex(
    -            sparkSession, metastoreRelation.catalogTable, sizeInBytes)
    -          if (lazyPruningEnabled) {
    -            catalog
    -          } else {
    -            catalog.filterPartitions(Nil)  // materialize all the partitions in memory
    +      // Here we should protect all relation get and create operation with lock while
big
    +      // table's CatalogFileIndex will take some time, only lock cachedDataSourceTables.put
    +      // will still cause driver memory waste. More detail see SPARK-18700.
    --- End diff --
    
    nit: probably don't need this comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message