spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...
Date Fri, 09 Dec 2016 19:43:21 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16219#discussion_r91771485
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
---
    @@ -376,7 +376,9 @@ class StateStoreSuite extends SparkFunSuite with BeforeAndAfter with
PrivateMeth
         val opId = 0
         val dir = Utils.createDirectory(tempDir, Random.nextString(5)).toString
         val storeId = StateStoreId(dir, opId, 0)
    -    val storeConf = StateStoreConf.empty
    +    val sqlConf = new SQLConf()
    +    sqlConf.setConf(SQLConf.MIN_BATCHES_TO_RETAIN, 2)
    +    val storeConf = StateStoreConf(sqlConf) // StateStoreConf.empty
    --- End diff --
    
    nit: this is not `StateStoreConf.empty`. Please remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message