spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From velvia <...@git.apache.org>
Subject [GitHub] spark issue #15219: [SPARK-14098][SQL] Generate Java code to build CachedCol...
Date Thu, 08 Dec 2016 20:32:33 GMT
Github user velvia commented on the issue:

    https://github.com/apache/spark/pull/15219
  
    Hi, in my experience, interfaces which are implemented by final methods are inlined just
fine in the JVM JIT…. but you might know more about this. 
    The point is more simplification and that the writers and setters are not needed by everyone….
 thanks
    
    I would think an API to iterate over non-null values would also be good, but we can’t
use the Iterator API in Java, it has too high overhead….. :-p
    
     
    > On Dec 8, 2016, at 12:29 PM, Kazuaki Ishizaki <notifications@github.com> wrote:
    > 
    > @velvia <https://github.com/velvia> Thank you for your comment. It is interesting
from the view of simplification.
    > On the other hand, I think that current implementation thinks about performance to
encourage method inlining for getter/setter (e.g. getInt()) and avoid interface call in JIT
compiler.
    > 
    > Let me think about this among simplification and performance. This refactoring should
be addressed by another PR.
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub <https://github.com/apache/spark/pull/15219#issuecomment-265846533>,
or mute the thread <https://github.com/notifications/unsubscribe-auth/ABA32-gBJXkZ8Xab57Rpee5k469mIo4Gks5rGGjAgaJpZM4KFRHu>.
    > 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message