spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #16149: [SPARK-18715][ML]Fix AIC calculations in Binomial...
Date Thu, 08 Dec 2016 06:46:14 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16149#discussion_r91453574
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
    @@ -215,6 +215,7 @@ class GeneralizedLinearRegression @Since("2.0.0") (@Since("2.0.0")
override val
        * Sets the value of param [[weightCol]].
        * If this is not set or empty, we treat all instance weights as 1.0.
        * Default is not set, so all instances have weight one.
    +   * In the Binomial model, weights correspond to number of trials.
    --- End diff --
    
    We should note that the weights should therefore be integers and that they'll be rounded
if they are not. Also say "Binomial family" instead of "Binomial model."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message