spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request #16186: [SPARK-18758][SS] StreamingQueryListener events f...
Date Wed, 07 Dec 2016 23:33:22 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16186#discussion_r91412582
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingQueryListenerBus.scala
---
    @@ -63,18 +83,29 @@ class StreamingQueryListenerBus(sparkListenerBus: LiveListenerBus)
         }
       }
     
    +  /**
    +   * Dispatch events to registered StreamingQueryListeners. Only the events associated
queries
    +   * started in the same SparkSession as this ListenerBus will be dispatched to the listeners.
    +   */
       override protected def doPostEvent(
           listener: StreamingQueryListener,
           event: StreamingQueryListener.Event): Unit = {
    +    val runIdsToReportTo = activeQueryRunIds.synchronized { activeQueryRunIds.toSet }
    --- End diff --
    
    otherwise the code would look like 
    ```
    case queryStarted: QueryStartedEvent =>
            if (activeQueryRunIds.synchronized { activeQueryRunIds.contains(queryStarted.runId)
}) {
              listener.onQueryStarted(queryStarted)
            }
          case queryProgress: QueryProgressEvent =>
            if (activeQueryRunIds.synchronized { activeQueryRunIds.contains(queryProgress.progress.runId)
}) {
              listener.onQueryProgress(queryProgress)
            }
          case queryTerminated: QueryTerminatedEvent =>
            if (activeQueryRunIds.synchronized { activeQueryRunIds.contains(queryTerminated.runId)
}) {
              listener.onQueryTerminated(queryTerminated)
              activeQueryRunIds.synchronized { activeQueryRunIds -= queryTerminated.runId
}
            }
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message